[hylafax-devel] Re: missing parts of security-patch.sh

[Tim Rice <tim@trr.metro.net>]

On Sun, 18 Jun 2000, Andy Sparrow wrote:

> --------
> Your message dated: Sun, 18 Jun 2000 17:17:06 +1000
> >At 05:46 PM 6/17/00 -0700, Andy Sparrow wrote:
> >>Namely:
> >>
[big snip]
> 
> >>iii)    You might want to add these lines to 'configure' around
> >>         about the definition settings for the socket API (roughly
> >>         line 2311 in my copy):
> >>
> >>         *-freebsd4*)    CONFIG_SOCKARGLENTYPE=u_int32_t;;
> >>         *-freebsd5*)    CONFIG_SOCKARGLENTYPE=u_int32_t;;

Reading below it looks like it should really be 
       *-freebsd4*)    CONFIG_SOCKARGLENTYPE=socklen_t;;
       *-freebsd5*)    CONFIG_SOCKARGLENTYPE=socklen_t;;
but that's imcompatable with the current code.
I ran into this with my Caldera distribution of linux
I've got some changes in my 4.0pl3 code base that will solve this.
I'll put together a patch.

> >
> >...are you sure the above isn't the 'size_t' type, that seems to be what 
> >alot of the other platforms are using.
> 
> Ummm, Yes, quite sure, see the definitions below...
> 
> FreeBSD 4.0-STABLE (and 5.0-CURRENT) is the chosen development platform 
> of the KAME Project (integrated IPv6 stack and tools & IPSec for IPv4/v6, 
> see http://www.kame.net).
> 
> The KAME code is an integrated part of FreeBSD since 4.0-RELEASE.
> OpenBSD 2.7 and up have it too, add NetBSD if you're talking development 
> trees. 
> 
> Perhaps that's the reason for the changes.
> 
> 
> FreeBSD 3.4-STABLE #3: Sun Apr  2 21:22:34 PDT 2000:
> 
>    *      @(#)socket.h    8.4 (Berkeley) 2/21/94
>    * $FreeBSD: src/sys/sys/socket.h,v 1.27.2.4 2000/03/08 06:32:44 fenner Exp $
>    */
> 
>   #ifndef _SYS_SOCKET_H_
>   #define _SYS_SOCKET_H_
> 
>   /*
>    * Definitions related to sockets: types, address families, options.
>    */
> 
>   /*
>    * Data types.
>    */
>   typedef u_char          sa_family_t;
>   typedef int             socklen_t;
> 
> 
> 
> FreeBSD 4.0-STABLE #0: Mon May 22 21:32:32 PDT 2000:
> 
>    *  @(#)socket.h    8.4 (Berkeley) 2/21/94
>    * $FreeBSD: src/sys/sys/socket.h,v 1.39 2000/03/11 19:51:04 shin Exp $
>    */
> 
>   #ifndef _SYS_SOCKET_H_
>   #define _SYS_SOCKET_H_
> 
>   /*
>    * Definitions related to sockets: types, address families, options.
>    */
> 
>   /*
>    * Data types.
>    */
>   typedef u_char      sa_family_t;
>   typedef u_int32_t   socklen_t;
> 
> 
> HTH
> 
> Regards,
> 
> AS
> 

-- 
Tim Rice				Multitalents	(707) 874-1130
tim@trr.metro.net



____________________ HylaFAX(tm) Developers Mailing List ____________________
 To unsub: mail -s unsubscribe hylafax-devel-request@hylafax.org < /dev/null