[hylafax-devel] Re: Your Hylafax dbely-3rtn.patch

[Dmitry Bely <dbely@mail.ru>]

Robert Hardy <rhardy@webcon.net> writes:

> I'm most pleased to see your recently posted dbely-3rtn.patch on hylafax.org.
> Your patch fixes a bunch of problems which I specifically need fixed.
> 
> I'm trying to get Hylafax working on Redhat 6.2. Once I do and have had a
> chance to test it, I would be please to share the resulting rpm/srpm.
> 
> This RPM build is quicky becoming a port session. I wish all the patches were
> in the CVS tree...

Yes, me too...

> My rpm must, unfortunately, work with libtiff V3.5.4.
>
> I get error messages like this with your old protocol-rtn.patch: 
> 
> FaxModem.c++: In method 'MemoryDecoder::MemoryDecoder(u_char *, u_int, u_long, u_int, boo
> FaxModem.c++:676: no matching function for call to 'MemoryDecoder::setRuns (uint16 *&, ui
> G3Decoder.h:71: candidates are: G3Decoder::setRuns(uint32 *, uint32 *, int)
> FaxModem.c++: In method 'Void MemoryDecoder::fixFirstEOL()':
> FaxModem.c++:735: warning: conversion to 'U_char *' from 'Const unsigned char *' discards
> 
> >From cursory inspection of your new patch, I see more instances of uint16 and expect
> similar problems.

Can you point to them? Personally I don't know other places that should
be changed while libtiff 3.4 -> 3.5 transition.

> Do you have a version of your patch which works with current V3.5.4 libtiff
> libraries which use internal 32 bit functions for setRuns among other things?

I hope to publish an updated patch (it will be libtiff 3.5 compatible among 
other thing) in a week. Subscribe to hylafax-devel and stay tuned. In the
meantime you can browse the previous patch discussion at

http://www.hylafax.org/archive/developers/index.html

> If you do I would appreciate it if you would share it with me as I would
> like to finally make hylafax a reliable fax solution for our needs.

Do you think that other Hylafax users don't need a reliable fax solution?
:-)

> Regards,
> Rob
> 
> --
> ----------------"Linux the choice of a GNU Generation!"-----------------
> Robert Hardy                                          C.E.O. Webcon Inc.
> rhardy@webcon.net      PGP Key available by finger        (613) 276-6206

Hope to hear from you soon,
Dmitry



____________________ HylaFAX(tm) Developers Mailing List ____________________
 To unsub: mail -s unsubscribe hylafax-devel-request@hylafax.org < /dev/null