Re: [hylafax-users] Problem authenticating through PAM

[Lee Howard <faxguy@xxxxxxxxxxxxxxxx>]

Klaus Rörig wrote:

> Lee Howard schrieb:
>  
>
> > Klaus Rörig wrote:
> >
> >    
> >
> > > Aug 14 12:03:09 fax-neu HylaFAX[24354]: pam_mysql - pam_mysql_sql_log()
> > > called.
> > > Aug 14 12:03:09 fax-neu HylaFAX[24354]: pam_mysql - pam_mysql_sql_log()
> > > returning 0.
> > > Aug 14 12:03:09 fax-neu HylaFAX[24354]: pam_mysql - pam_mysql_converse()
> > > called.
> > > Aug 14 12:03:09 fax-neu HylaFAX[24354]: CAUGHT SIGNAL 11
> > >
> > >      
> > It seems to be saying that hfaxd is segfaulting on PAM authentication.
> >
> > What version of HylaFAX are you using?  Did you build it from source? 
> > Or is it a binary install of some kind?
> my version is 5.1.5 build from source on SuSE SLES 10 with pam_mysql 0.7RC1.

The hfaxd child process segfaults because pam_mysql.so segfaults in 
pam_mysql_converse.  It's a silly bug in pam_mysql.  The attached bug 
should fix it.  Also see:

http://sourceforge.net/tracker/index.php?func=detail&aid=1792572&group_id=5741&atid=305741

Thanks,

Lee.

--- pam_mysql-0.7RC1/pam_mysql.c	2006-01-09 02:35:59.000000000 -0800
+++ pam_mysql-0.7RC1.new/pam_mysql.c	2007-09-11 10:59:47.494608680 -0700
@@ -3205,7 +3205,7 @@
 	}
 
 	for (i = 0; i < nargs; i++) {
-		if (resps[i].resp != NULL &&
+		if (resps != NULL && resps[i].resp != NULL &&
 				NULL == (retval[i] = xstrdup(resps[i].resp))) {
 			syslog(LOG_AUTHPRIV | LOG_CRIT, PAM_MYSQL_LOG_PREFIX "allocation failure at " __FILE__ ":%d", __LINE__);
 			err = PAM_MYSQL_ERR_ALLOC;