[hylafax-users] [Ann.]: Patch to CAPI4HylaFAX 01.01.02

[Norbert Warmuth <n.warmuth@tiscon.com>]

Hello,

at [1] I have placed a patch to AVM's CAPI4HylaFAX [2] release
01.01.02 (the site at [1] is in german but below you will find an
english translation of the important parts). 
 
This patch solves some issues with the latest CAPI4HylaFAX release and
improves slightly the integration with HylaFAX. If someone finds
errors in the patch I would appreciate a short notice. 

Regards,
Norbert


References:
[1] http://www.tiscon.com/down/capi.php
[2] ftp://ftp.avm.de/cardware/fritzcrd.pci/linux/capi4hylafax-01.01.02.tar.gz


Bugs fixed with capi4hylafax-01.01.02-2001-05-17d_ext.diff.gz:
--------------------------------------------------------------
* c2faxsend: Detect errors after the data connection has been
established.

* c2faxsend: Count the number of actually transmitted pages
instead of the number of pages which have been prepared for 
transmission (it's not accurate but better than it's used to be). 
Note: This part of the patch isn't optimal and it might be possible
and much easier just to use the parameter NCPI in DoDisconnecting(). 
I hadn't yet time to verify this. 

* src/capi/CapiMsg.cpp (CCAPI20_MsgBase::GetMessageComplete,
message CAPI_DATA_B3):  Don't cast the message parameters to
(cp_datab3conf *) - size doesn't fit.

* src/convert/sff2huf.cpp : Increase HUFF_SFF_ADD_TO_PUT_IN. 
Expansion of empty lines sometimes corrupted the Hufman buffer.

* src/faxrecv/faxrecv.cpp (CFaxReceive::GetData): Check for full
queue after calling SffFilter.PutChar(). If you have problems
receiving empty or almost empty pages at 196 lpi this change and 
the change in sff2huf.cpp is supposed to fix it. 

If tiff files are written: Record for every page the amount of
seconds needed to send the page instead of the amount of seconds
since the transmission started. faxinfo(1m) from HylaFAX expects
it this way.

(CFaxReceive::IsDisconnected): Flush the log file to disk before
invoking FaxRcvdCmd. 

(CFaxReceive::IsConnected): Notify HylaFAX about status "BUSY".



Improvements/New features:
--------------------------
* Add HylaFAX accounting to c2faxsend and c2faxrcvd. To enable
accounting you will need compiled HylaFAX sources (configure
option 	--with-hylafax-srcdir). See xferfaxstats(1m) for
information about accounting.

* c2faxrecv: Fill in "signalrate" und "dataformat" in the Job
file.

* config.faxCAPI: New option "PolledRetrievalEnabled". Determines
which polling capabilities c2facrev announces to the HylaFAX
queuer process (from looking at the sources I'm not sure whether
CAPI4HylaFAX supports polling of remote documents at all):
0: device is not capable of polling for remote documents
1: device is capable of polling for remote documents



____________________ HylaFAX(tm) Users Mailing List _______________________
 To unsub: mail -s unsubscribe hylafax-users-request@hylafax.org < /dev/null