[hylafax-devel] Re: missing parts of security-patch.sh

[Robert Colquhoun <rjc@trump.net.au>]

At 05:46 PM 6/17/00 -0700, Andy Sparrow wrote:
>Namely:
>
>i)      Testing shell variables that may not be set is dangerous,
>         e.g.:
>
>         if [ -f $SYSINIT ]
>         ...
>
>         is dodgy if 'SYSVINIT' is never set.

SYSVINIT should *always* be set.  Though looking at configure it seems this 
has somehow being mucked up....and the Makefile in the etc directory seems 
broken now too.

>
>         Of course, on BSD-ish systems, 'SYSINIT' doesn't get set...


On BSD type systems the sysvinit script should be copied to the sbin 
directory instead.

So that you can start and stop hylafax easily at the command line ie 
'hylafax start' and 'hylafax stop'




>ii)     Some systems break the Adobe Font Metrics out of the
>         Ghostscript package altogether and install it as a separate
>         dependancy (presumably so that multiple ghostscript installs
>         can be located in versioned directory names, in a similar
>         way to how I can have multiple versions of Tcl/Tk installed
>         on the same system).

Are you saying the metric files are separate from the fonts themselves?

>         On such systems (FreeBSD at least, maybe also the other BSD
>         systems that use the 'ports' system), PATH_AFM would get set
>         just fine by the "last ditch" code if it weren't for the call
>         to the 'getGSFonts' function - which obligingly(?) finds the
>         Ghostscript 'afm' directory instead, thus no further
>         processing is performed.

Er i dont understand what you mean - the idea is that the document is 
generated using the *same* fonts that ghostscript is going to use to 
actually rasterize the document.

>         However, this particular 'afm' directory doesn't have the
>         Courier font definition required for the package to run,
>         thus nothing works when the build is complete.


Does it have other .afm files with encoded names?  If so textfmt et al will 
use the Fontmap file to find the correct font.


>iii)    You might want to add these lines to 'configure' around
>         about the definition settings for the socket API (roughly
>         line 2311 in my copy):
>
>         *-freebsd4*)    CONFIG_SOCKARGLENTYPE=u_int32_t;;
>         *-freebsd5*)    CONFIG_SOCKARGLENTYPE=u_int32_t;;

...are you sure the above isn't the 'size_t' type, that seems to be what 
alot of the other platforms are using.

- Robert




____________________ HylaFAX(tm) Developers Mailing List ____________________
 To unsub: mail -s unsubscribe hylafax-devel-request@hylafax.org < /dev/null