[hylafax-devel] Re: My RTN patch and many other changes/enhancements, third edition :-)

[Dmitry Bely <dbely@mail.ru>]

"Bernd Proissl" <news@proissl.de> writes:

> > Now against the current CVS!
> i will have to make this work first before i can test you patches :-(
> 
> > The following is included:
> ...
> > Maybe "Ignore" option should be default?
> i would say YES
> 
> > 4. Class2.0 post-page-handling code corrected. (faxd/Class20.c++)

Nothing special, just issue AT+FPS after ERROR to find out the correct NAK
reason (was present in the previous patch).

> > 5. Class1 post-page-handling code corrected. In case of RTN it behaves the
> > same (correct) way as in Class2/2.0. (faxd/Class1Send.c++)
> can you please describe the symptoms of these errors?

[---cut---]
	    case FCF_RTN:		// nak, retry after retraining
		if ((++ntrys % 2) == 0) {
		    /*
		     * Drop to a lower signalling rate and retry.
		     */
		    if (params.br == BR_2400) {
			emsg = "Unable to transmit page"
			       " (NAK at all possible signalling rates)";
			return (send_retry);
		    }
		    --params.br;
		    curcap = NULL;	// force sendTraining to reselect
		}
		if (!sendTraining(params, 3, emsg))
		    return (send_retry);
		morePages = true;	// force continuation
		next = params;		// avoid retraining above
		break;
[---cut---]

This is *nonsense*. Why "if ((++ntrys % 2) == 0)" ??? Why handle RTN
differently for Class1 and Class2/2.0 ??? I do not know who wrote the code
above, but definitely not Sam Leffler :-)

> do (did?) they result in "No response to EOP" or "no response to MPS"
> messages?

No. They are just RTN-related.

Hope to hear from you soon,
Dmitry



____________________ HylaFAX(tm) Developers Mailing List ____________________
 To unsub: mail -s unsubscribe hylafax-devel-request@hylafax.org < /dev/null