[hylafax-devel] Re: My RTN patch and many other changes/enhancements, third edition :-)

[Dmitry Bely <dbely@mail.ru>]

Tim Rice <tim@trr.metro.net> writes:

> > 7. NSF decoding routines, identifing remote fax equipment and remote
> > station ID are added. E.g., here is a quote from my log:
> > 
> > [---cut---]
> > Apr 13 19:56:43.17: [17273]: --> [4:+FCO]
> > Apr 13 19:56:43.17: [17273]: --> [58:+FNF:00 00 0E 00 00 00 16 0F 01 03 00 10 05 02 95 C8 08   ]
> > Apr 13 19:56:43.17: [17273]: REMOTE NSF "00 00 0E 00 00 00 16 0F 01 03 00 10 05 02 95 C8 08"
> > Apr 13 19:56:43.18: [17273]: NSF remote fax equipment: Panasonic KX-F780
> > Apr 13 19:56:43.18: [17273]: --> [26:+FCI:                     ]
> > Apr 13 19:56:43.18: [17273]: REMOTE CSI ""
> > Apr 13 19:56:43.18: [17273]: --> [20:+FIS:1,3,0,2,1,0,0,4]
> > Apr 13 19:56:43.18: [17273]: --> [2:OK]
> > [---cut---]
> > 
> > (faxd/NSF.h, faxd/NSF.c++, faxd/FaxModem.h,
> > faxd/FaxModeM.c++). Contribution to my NSF list is welcome! :-)
> 
> Hmm, looking at your patch I'm thinking that things like
> ...
> static const NSFData KnownNSF[] =
> {
>     {"\x00\x00\x09", NULL,        false },
>     {"\x00\x00\x0E", "Panasonic", false, 3, 4, Panasonic0E },
>     {"\x00\x00\x11", "Canon",     false },
>     {"\x00\x00\x19", "Xerox",     true  },
> ...
> should be read from a config file at runtime so you don't have to
> recompile when you add to the list.

May be, but then we have to check their correctness, and explain in detail
to each and every newbie, how to edit this configuration data. Definitely
not now :-)

> > 8. Default value for ModemResetCmds is now "ATZ". (ModemSoftResetCmd
> > parameter was never used :-)) (faxd/ModemConfig.c++, man/config.4f)
> 
> I agree with Steve, "ATZ" is not a good idea.

Why? It's semi-standard way to _reset_ any modem. Most fax applications,
known to me, behave just this way (ask Harald Pollack :-))). Also, have you 
noted, that ModemSoftResetCmd, described in config.4f, is *never* *used*?
Comment from there

[---cut---]
In addition the soft reset command (usually ``\s-1ATZ\s+1'')
should not be included in this string; the servers issue this
command explicitly.
[---cut---]

... simply has nothing to do with the reality :-)

Hope to hear from you soon,
Dmitry



____________________ HylaFAX(tm) Developers Mailing List ____________________
 To unsub: mail -s unsubscribe hylafax-devel-request@hylafax.org < /dev/null