[hylafax-devel] Re: problem to submit a fax request

[Robert Colquhoun <rjc@trump.net.au>]

At 01:13 AM 3/6/00 +0000, Darren Nickerson wrote:

>Looks good to me! Can anyone suggest a reason I should not commit this 
>change? Is this the right way to fix the problem?

The O_EXCL flag was put in as part of the suse security patches(of which i 
still have the one on ip source routed packets to commit).  The idea is 
that if you have to create the file ie O_CREAT you also need exclusive 
access to it to prevent other people playing stupid games linking the file 
to something else and you destroying the something else when you write to 
what you think is the seqf  file.

The suse patch also changed the privileges to 0600 from 0660 i think.

...but obviously this doesnt work, hylafax obviously needs to have 
multiple processes(perhaps hfaxd and faxq) open the file at the same time 
or something....the hylafax queueing design is very bad, about the middle 
of last year i was trying to add job batching but the existing code was so 
awful i gave up and started planning a rewrite of the whole thing from 
scratch....unfortunately since work has intervened and i have no free time 
at all to do this.

- Robert