HylaFAX The world's most advanced open source fax server

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]

[hylafax-users] bug fix #314 breaks tkhylafax



Included in release 4.1.5 is a bug fix for 'sendfax' that breaks the
tkhylafax client.  It might break other clients as well.

This fix checks for options after the destination options, aborts sending
of the fax, and returns a non-zero status.  So any client (like tkhylafax 
3.0 - 3.2beta) that puts in an option, like -i, after the destination,
will fail.

Here's a patch against tkhylafax-3.2beta that fixes it.


*** faxIt.t~    Sat Feb  2 17:30:57 2002
--- faxIt.t     Fri Nov  8 11:25:22 2002
***************
*** 66,80 ****
                  $Th_Info(notifyOnRetry)
  
      if {[string length $Th_Info(name)]} {
-         # This MUST appear.
-       regsub -all {["'$\\]} $Th_Info(name) {\\&} name
-         append options " -d \"$name@$Th_Info(phone)\""
- 
          # Make an ID string for later usage
        regsub -all {["'$\\]} $Th_Info(company) {\\&} company
          append options " -i \"$name@$company\"" 
      } else {
!         # This MUST appear.
          append options " -d $Th_Info(phone)"
      }
  
--- 66,80 ----
                  $Th_Info(notifyOnRetry)
  
      if {[string length $Th_Info(name)]} {
          # Make an ID string for later usage
+       regsub -all {["'$\\]} $Th_Info(name) {\\&} name
        regsub -all {["'$\\]} $Th_Info(company) {\\&} company
          append options " -i \"$name@$company\"" 
+ 
+         # This MUST appear last.
+         append options " -d \"$name@$Th_Info(phone)\""
      } else {
!         # This MUST appear last.
          append options " -d $Th_Info(phone)"
      }

____________________ HylaFAX(tm) Users Mailing List _______________________
  To subscribe/unsubscribe, click http://lists.hylafax.org/cgi-bin/lsg2.cgi
 On UNIX: mail -s unsubscribe hylafax-users-request@hylafax.org < /dev/null
  *To learn about commercial HylaFAX(tm) support, mail sales@hylafax.org.*




Project hosted by iFAX Solutions