Re: [hylafax-users] Update on Problem with Distinctive Ring (346 patch does not fix CID issue)

["Sunil William Savkar" <savkar@inthespace.com>]

Yes, oddly with a variety of "fixes" I have tried of the type you
indicated below, I am still having the two (sort of) independent
problems:

(i) "RING A" versus "RING B" is not distinguished (are the spaces
causing problems with the .length() operator?

(ii) cid.name and cid.number are being set incorrectly to the RING
string above in (i).  Again, since RING A and RING B apparently are not
being properly detected, somehow even when I hardcode extended ring to
be "RING;" and call parseCID only within this then clause, I still get
RING A or RING B as the result of both cid.number and cid.name.

I would like to do some debugging, but need to know the format of fxStr
structure.

Where is it defined with its operators?  I have not been able to figure
that out. Also, where are the macros strnequ and strequ.  They
apparently seem to work with fxStr structures.

Again, I apologize in advance, as I am not a C++ programmer, so not sure
if there is something obvious in inserting debug prints.  I wanted to
basically have some prints of various variables in these functions.

However, since I have some time and have the peculiarities, I'd love to
see to track it down and, if necessary, help find a fix.

Thanks.

Sunil

p.s.  Should this thread move over to development?

-----Original Message-----
From: hylafax-users-bounce@hylafax.org
[mailto:hylafax-users-bounce@hylafax.org] On Behalf Of Patrice Fournier
Sent: Wednesday, September 04, 2002 8:35 AM
To: savkar@inthespace.com
Cc: 'Lee Howard'; hylafax-users@hylafax.org
Subject: Re: [hylafax-users] Update on Problem with Distinctive Ring
(346 patch does not fix CID issue)

Quoting Sunil William Savkar <savkar@inthespace.com>:

> It also does not fix the "mystified" situation I had with CID.  I
> demystified it by staring at the code.
> 
> Since RING A does not match to anything else in the if-then-else
clause
> because of the separate bug with matches between the distinctive ring
> string and the buffer, it defaults to calling parseCID at the end
(from
> ModemConfig.c++).  The parseCID script performs a stringcompare
between

Right, the parseCID line should be in the if block as such:

    else {
        if (strneq(rbuf, conf.ringExtended,
          conf.ringExtended.length())) {        // extended RING
            n--;
            conf.parseCID(rbuf, cinfo);
        }
        break;

or to stay consistent, we could also rewrite it as such:

    else if (strneq(rbuf, conf.ringExtended,
      conf.ringExtended.length()))        // extended RING
        conf.parseCID(rbuf, cinfo);
    else
        break;


> Thus CIDName and CIDNumber are thus both incorrectly set to RING A
> instead. 

Right.

> Mystery solved, bug still there with patch 346 which does not touch
the
> parseCID routine.  Have not tried to fix yet but may be as simple as
> switching the two arguments to the strnequ() macro.

CID would still be parsed, but the RING should not get counted and 
answered though. Are you saying that faxgetty still answer the phone
after 
the patch from bug 346 and the RingExtended configuration option was 
added?

-- 
Patrice Fournier
pfournier@loups.net

____________________ HylaFAX(tm) Users Mailing List
_______________________
  To subscribe/unsubscribe, click
http://lists.hylafax.org/cgi-bin/lsg2.cgi
 On UNIX: mail -s unsubscribe hylafax-users-request@hylafax.org <
/dev/null
  *To learn about commercial HylaFAX(tm) support, mail
sales@hylafax.org.*




____________________ HylaFAX(tm) Users Mailing List _______________________
  To subscribe/unsubscribe, click http://lists.hylafax.org/cgi-bin/lsg2.cgi
 On UNIX: mail -s unsubscribe hylafax-users-request@hylafax.org < /dev/null
  *To learn about commercial HylaFAX(tm) support, mail sales@hylafax.org.*