Re: flexfax: HylaFAXServer::getSequenceNumber() shouldn't use O_EXCL

["Phil Watkinson" <Pkwatkinson@tesco.net>]

Mark Burton <markb@ordern.com> wrote:
> 
> I have installed a recent version of hylafax 4.1beta2 (from the CVS
> repository) on my Linux box (2.2.14) and a problem I had to fix was
> that sends were failing with messages like this:
> 
> Mar 16 13:53:00 rook HylaFAX[14565]: docq/seqf: open: File exists
>

Hi, Mark,
I think it would be a good idea for you to subscribe to the hylafax
developers list (see http://www.hylafax.org/mailing-lists.php for info)
since this is one of the two showstopping bugs thats preventing the
release of the next beta (the other is the problem with libtiff-3.5.x).

 
> It seems to me that the code in HylaFAXServer::getSequenceNumber()
> can't possibly work as it combines O_EXCL and O_CREAT open modes which
> will cause the open to fail if the file exists.
>

Quite. The O_EXCL was added as part of the SuSE security patches (and
permissions changed from 660 to 600), but it plainly doesn't work. 


> I have therefore removed the O_EXCL and it seems to work OK.
>

Darren has proposed the same for the CVS - hopefully the change will
be applied soon.

 
> One other thing, the files that are created in the docq directory are
> being created with a owner id of uucp (good) and a group id of 60002
> (maybe not good). Is this how it should be?
> 

Yes, I think so; unfortunately I cannot check on my production system 
at the moment.

Regards,
Phil Watkinson,
Leicester, UK.