HylaFAX The world's most advanced open source fax server

[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index]

a possible bug with sendpage




i am using hylafax-v4.0pl2 on a sparc solaris 2.6 system (gcc 2.7.2) and am
seeing a problem with sendpage and pagermap.  i wrote the following in
etc/pagermap:

(.*)@(.*)       \2/\1

however, this didnt work as expect, pagesend/hfaxd attempted to dial
\2 instead of the second regexp match.  see below:

Apr 17 09:43:59.01: [  903]: SESSION BEGIN 00000017 12022
Apr 17 09:43:59.02: [  903]: SEND PAGE: JOB 26 DEST \2 COMMID 00000017
Apr 17 09:45:01.88: [  903]: PAGE FAILED: No carrier detected
Apr 17 09:45:02.14: [  903]: SESSION END

apparently hfaxd only applies the regexp to the PIN and not the dial string.
the patch below fixes this (actually you might just apply subRHS() before
finding the / and splitting into a dialstring and pin, but this works and the
code was difficult to read)

*** SNPPServer.c++      Fri Apr 17 10:07:40 1998
--- SNPPServer.c++.000  Fri Apr 17 10:04:42 1998
***************
*** 299,308 ****
                            number = np;
                            pin = cp;
                            if (re)                     // do substitutions
-                           {
                                subRHS(pin, *re, pagerID);
-                               subRHS(number, *re, pagerID);
-                           }
                        } else {                        // <dialstring>
                            number = np;
                            pin = pagerID;
--- 299,305 ----


why do i need this?  not everyone has the same pager service and maintaining
the pagermap file for everyone would be very painful.




Project hosted by iFAX Solutions